Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve quote block styles #1131

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Improve quote block styles #1131

merged 1 commit into from
Sep 11, 2024

Conversation

annarhughes
Copy link
Member

@annarhughes annarhughes commented Sep 11, 2024

What changes did you make?

Improved the styling of the quote block, by moving the quote mark to the side instead of above the text.
Also slighting increased the image size and padding, and slightly reduced the text sizes and line heights.

Why did you make the changes?

Styling improvements flagged by Nadine

Before/after

Screenshot 2024-09-11 at 17 20 06 Screenshot 2024-09-11 at 17 19 50 Screenshot 2024-09-11 at 17 20 21 Screenshot 2024-09-11 at 17 20 30

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bloom-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 4:21pm

@annarhughes annarhughes merged commit 712695a into develop Sep 11, 2024
8 checks passed
@annarhughes annarhughes deleted the fix-quote-block branch September 11, 2024 16:26
Copy link

cypress bot commented Sep 11, 2024

Bloom frontend    Run #715

Run Properties:  status check failed Failed #715  •  git commit 712695a156: feat: improve quote block styles (#1131)
Project Bloom frontend
Branch Review develop
Run status status check failed Failed #715
Run duration 08m 35s
Commit git commit 712695a156: feat: improve quote block styles (#1131)
Committer Anna Hughes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 84
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Tests for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant