Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor partner welcome pages #1134

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Conversation

annarhughes
Copy link
Member

What changes did you make?

  • Refactors the partner welcome page to match the design of the home page (+ 2 partner sections)
  • Refactors use of partner code on /welcome page - if a code query param is found on /welcome or /register, this will now be saved in state, to be retrieved on the register page. The WelcomeCodeForm was removed.
  • Removes the /partnerships/partner-name page as this is now redundant as the info is included on the welcome page. Redirects have been set up

Why did you make the changes?

As part of a redesign of partner welcome pages, to bring them in line with the new home page design

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bloom-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 3:24pm

@annarhughes annarhughes merged commit 0a38098 into develop Sep 12, 2024
7 checks passed
@annarhughes annarhughes deleted the refactor-partner-welcome-page branch September 12, 2024 15:28
Copy link

cypress bot commented Sep 12, 2024

Bloom frontend    Run #720

Run Properties:  status check failed Failed #720  •  git commit 0a38098922: feat: refactor partner welcome pages (#1134)
Project Bloom frontend
Branch Review fix-partner-welcome-tests
Run status status check failed Failed #720
Run duration 10m 08s
Commit git commit 0a38098922: feat: refactor partner welcome pages (#1134)
Committer Anna Hughes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 4
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 81
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Tests for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant