Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build paths #1140

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Fix build paths #1140

merged 2 commits into from
Sep 16, 2024

Conversation

annarhughes
Copy link
Member

What changes did you make?

Fixed getStaticPaths functions to ensure only storyblok pages that have been published, are added to the static paths list.

Why did you make the changes?

When building the app, there were many 404 errors for fetching storyblok data for pages. The errors were diluting the logging for builds - it's now easier to see the relevant issues from build logs

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bloom-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 2:58pm

@annarhughes annarhughes merged commit 4371b46 into develop Sep 16, 2024
7 checks passed
@annarhughes annarhughes deleted the fix-build-pages branch September 16, 2024 15:01
Copy link

cypress bot commented Sep 16, 2024

Bloom frontend    Run #729

Run Properties:  status check passed Passed #729  •  git commit 4371b46d0e: fix: storyblok build paths (#1140)
Project Bloom frontend
Branch Review develop
Run status status check passed Passed #729
Run duration 08m 23s
Commit git commit 4371b46d0e: fix: storyblok build paths (#1140)
Committer Anna Hughes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 83
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant