Refactor get user #970
Merged
Refactor get user #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
annarhughes
force-pushed
the
refactor-get-user
branch
from
25d7238
to
5309265
Compare
annarhughes
force-pushed
the
refactor-get-user
branch
from
17eb61d
to
55fdc99
Compare
annarhughes
force-pushed
the
refactor-get-user
branch
from
55fdc99
to
cf2431f
Compare
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make?
Refactored user auth functionality to use GET instead of POST endpoint. Removed duplication of auth functionality across
LoginForm,RegisterFormandAuthGuard, using a newuseLoadUserhook thats available on every page. This simplified the auth guards and removed guards/publicPageDataWrapper.tsxWhy did you make the changes?
Following updates in backend PR to use GET instead of POST request