Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for API Shield client certificates endpoints #1686

Conversation

arkadiuss
Copy link

@arkadiuss arkadiuss commented Apr 7, 2024

Hello! I would like to add support for "API Shield client certificates for a zone" endpoints (docs) because the functionality is missing in the current version and would be useful especially in the Terraform provider. I did my best to follow practices from other places.

Description

I found an issue created some time ago here. Changes include implementation of the following endpoints:

Has your change been tested?

Unit tests and running the new functions locally on my account.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link
Contributor

github-actions bot commented Apr 7, 2024

changelog detected ✅

@jacobbednarz
Copy link
Member

thanks for the effort with the PR here!

unfortunately, v2 is pretty close to being released and it looks like all of these endpoints are already covered so we won't be adding them to the legacy SDK.

if you want to use this now, you can checkout v2.0.0 Beta and use that instead. there will be work later this week in the Terraform provider supporting mux'ing the two versions alongside each other.

@arkadiuss
Copy link
Author

great, thank you for the information, I totally understand that. I will wait till it will be available in the Terraform provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants