Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null script_name field in worker script settings #2724

Conversation

gnharishkumar13
Copy link
Contributor

Related to #1517

Allow the script_name field in the worker script's settings to be null.

  • Change the ScriptName field in WorkerDurableObjectBinding struct to a pointer to a string in workers_bindings.go.
  • Update the serialize method in WorkerDurableObjectBinding to handle null values for script_name.
  • Update the ListWorkerBindings function in workers_bindings.go to handle null script_name values.
  • Add test cases in workers_bindings_test.go to verify handling of null script_name values.
  • Update the formatMultipartBody function in workers.go to handle null script_name values.
  • Add test cases in workers_test.go to verify handling of null script_name values.

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/cloudflare-go/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

@gnharishkumar13 gnharishkumar13 deleted the fix-null-script-name branch July 4, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant