add the ability to set the protocol(s) when creating a websocket client #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kflansburg
previously approved these changes
Feb 28, 2024
kflansburg
approved these changes
Feb 28, 2024
jdon
pushed a commit
to jdon/workers-rs
that referenced
this pull request
Mar 27, 2024
…nt (cloudflare#424) * add the ability to set the protocol(s) when creating a websocket client * fmt and clippy --------- Co-authored-by: Kevin Flansburg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found myself needing to set the protocol when creating a websocket client. This exposes a new function that allows the caller to the protocol.
Pretty straightforward, happy to adjust as needed!