Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use method of http crate instead of the original method #428

Closed
wants to merge 3 commits into from

Conversation

fwqaaq
Copy link

@fwqaaq fwqaaq commented Dec 24, 2023

close: #426

In the original worker-rs, the Method was limited to only 8 standard methods. However, in reality, there are more than 8 methods defined on top of HTTP, and custom methods cannot be created. But, using JavaScript, the custom methods are possible.

I believe this is a bug, using http crate from Rust is a better choice, because reqwest and hyper are based on it. So I hope the offical team can address and fix this bug.

@avsaase
Copy link
Contributor

avsaase commented Mar 10, 2024

I think this is superseded by #286

@kflansburg
Copy link
Member

Superseded by #477

@kflansburg kflansburg closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] use http::Method instead of re-implementing Method.
3 participants