Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibility with js-sys 0.3.70 #619

Closed
wants to merge 1 commit into from

Conversation

fornwall
Copy link
Contributor

Fixes #617.

@gmemstr
Copy link

gmemstr commented Aug 14, 2024

@fornwall I tried to do the same in #618 but it didn't work out - some of the underlying types changed a bit more than expected. Worth runing cargo check locally.

kanarus added a commit to ohkami-rs/ohkami that referenced this pull request Aug 15, 2024
@andrewdavidmackenzie
Copy link
Contributor

Is this going to be merged any time soon (and a release with the fix published)?

My project that uses workers is failing due to this one.

I guess I'll implement one of the workarounds mentioned, but wanted to know what the timing on the "real" fix might be.

Thanks

@kflansburg
Copy link
Member

Is this going to be merged any time soon (and a release with the fix published)?

My project that uses workers is failing due to this one.

I guess I'll implement one of the workarounds mentioned, but wanted to know what the timing on the "real" fix might be.

Thanks

This was broken in the upstream crate, and I would like to see their response to the issue first. If we merge this, and they revert / yank the breaking change, then it will be broken again. If we pin the crate for now, I suspect that will not entirely solve the problem as others are running into conflicts when using the pinned version with other crates.

@kflansburg
Copy link
Member

Closing in favor of #621

@kflansburg kflansburg closed this Aug 19, 2024
kanarus added a commit to ohkami-rs/ohkami that referenced this pull request Aug 20, 2024
* @2024-08-13 18:25+9:00

* next: add `format::{Query, builtin::〜}`

* next: update examples

* next: in-place validation with `Schema` specialization in nightly

* @2024-08-14 03:11+9:00

* next: docs

* next: pass CI

* wait cloudflare/workers-rs#619 to be merged

* fix doc of `format::File`

* thanks to cloudflare/workers-rs#621 & fix benches/src/bin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] js-sys 0.3.70 breaking change
4 participants