Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] Fix for CMake error when calling set_property on aliased targets #20667

Open
wants to merge 8 commits into
base: v4
Choose a base branch
from

Conversation

rh101
Copy link
Contributor

@rh101 rh101 commented May 5, 2021

ALIAS targets are non-modifiable, so set_property cannot be called on them. This fix will attempt to extract the real target from the alias, and if it exists, it will use that target value for the call to set_property.

This issue appeared when using CMake 3.20.2 when attempting to compile for iOS.

In addition to that, the lists generated by both search_depend_libs_recursive and get_target_depends_ext_dlls will have any duplicate entries removed, since the entries were being processed multiple times in later sections of code.

@rh101 rh101 changed the title Fix for CMake error when calling set_property on aliased targets [v4] Fix for CMake error when calling set_property on aliased targets May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant