Add globbing support #1524
Open
Add globbing support #1524
+3,551
−635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can wait to see this merged. Interesting how the globbing was silently removed on each major version... |
lishaduck
force-pushed
the
globs
branch
2 times, most recently
from
d96bd30
to
bfb40d9
Compare
|
I tried deduping deps, but it only found duplicate devdeps, so the build didn't get any smaller 😢 |
|
It might make sense to use @actions/glob, like |
I hadn't heard of that, but yes, it looks like a better alternative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #770 for real.
Personally, I think this change belongs in the cli, but I decided that rewriting the argument parsing there was a much larger endeavor than this.
Tests are failing because it now globs the files, but they don't actually exist. I suppose we need fixtures then? Shouldn't be breaking in practice though.