-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator - support partitioning of the slot id space #890
base: master
Are you sure you want to change the base?
Conversation
…tion of validation params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, great job! 👏
I have a few (detailed) comments, mostly because I had already gone through the mental hurdles of this task in the past, so I knew of some nuances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, Marcin! I'll approve now as there is nothing blocking.
On a formatting note, it would be good if you could limit line length to 80 chars please 🙏
Will be done. |
…alidated without limit when maxSlots is set to 0
This PR, addresses issue #457 (please refer to the issue discussion for more context info so that we do not have to duplicate it all here).
To shortly summarise issue #457: we want to be able to tell the validator what partition of the whole slot id space it should observe and help validating.
To achieve that, we provide two new CLI/config parameters:
validator-partition-size
- to indicate number equal partitions dividing the whole slot id space,validator-partition-index
- to indicate the index of the portion observed by the validator.The validator will only consider a slot with slot id
slotId
for validation if it matches the following criteria:To be done in this PR: