Skip to content

Commit

Permalink
Enable DEFAULT_IS_NODE_AWARE for testing
Browse files Browse the repository at this point in the history
  • Loading branch information
@michaeljmarshall
michaeljmarshall committed Sep 18, 2024
1 parent 6f6d711 commit 8c4b186
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/java/org/apache/cassandra/db/compaction/unified/Controller.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,8 @@ public abstract class Controller
static final long MIN_TARGET_SSTABLE_SIZE = 1L << 20;

static final String IS_NODE_AWARE_OPTION = "is_node_aware";
public static final boolean DEFAULT_IS_NODE_AWARE = Boolean.parseBoolean(System.getProperty(PREFIX + IS_NODE_AWARE_OPTION));
// Temporarily enable by default for testing
public static final boolean DEFAULT_IS_NODE_AWARE = Boolean.parseBoolean(System.getProperty(PREFIX + IS_NODE_AWARE_OPTION, "true"));

/**
* Provision for growth of the constructed SSTables as the size of the data grows. By default the target SSTable
Expand Down

3 comments on commit 8c4b186

@cassci-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build rejected: 2389 NEW test failure(s) in 4 builds., Build 4: ran 17001 tests with 2417 failures and 111 skipped.
Butler analysis done on ds-cassandra-pr-gate/node-aware-shard-manager vs last 16 runs of ds-cassandra-build-nightly/main.
Showing only first 13 NEW test failures
org.apache.cassandra.db.commitlog.BatchCommitLogTest.testHeaderOnlyFileFiltering[5]: test failed in the recent build. No failures on upstream;
branch story: [F+++] vs upstream: [++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++]; [NEW]
org.apache.cassandra.distributed.test.FullRepairCoordinatorNeighbourDownTest.validationParticipentCrashesAndComesBack[SEQUENTIAL/true]: test failed in the recent build. No failures on upstream;
branch story: [F+++] vs upstream: [++++++++++++++++]; [NEW]
org.apache.cassandra.distributed.test.FullRepairCoordinatorFastTest.simple[SEQUENTIAL/true]: test failed in the recent build. No failures on upstream;
branch story: [F+++] vs upstream: [++++++++++++++++]; [NEW]
org.apache.cassandra.io.sstable.LegacySSTableTest.testAutomaticUpgrade: test failed in the recent build. No failures on upstream;
branch story: [F+++] vs upstream: [++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++]; [NEW]
org.apache.cassandra.db.RecoveryManagerFlushedTest.testWithFlush[1]: test failed in the recent build. No failures on upstream;
branch story: [F+++] vs upstream: [++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++]; [NEW]
org.apache.cassandra.db.RecoveryManagerTest.testRecoverPIT[2]: test failed in the recent build. No failures on upstream;
branch story: [F+++] vs upstream: [++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++]; [NEW]
org.apache.cassandra.db.commitlog.BatchCommitLogTest.testEqualRecordLimit[4]: test failed in the recent build. No failures on upstream;
branch story: [F+++] vs upstream: [++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++]; [NEW]
org.apache.cassandra.distributed.test.PreviewRepairCoordinatorNeighbourDownTest.validationParticipentCrashesAndComesBack[SEQUENTIAL/false]: test failed in the recent build. No failures on upstream;
branch story: [F+++] vs upstream: [++++++++++++++++]; [NEW]
org.apache.cassandra.db.VerifyTest.testVerifyPartitionIndex: test failed in the recent build. No failures on upstream;
branch story: [F+++] vs upstream: [+S+++S+++S+++S+++S+++S+++S+++S+++S+++S+++S+++S+++S+++S+++S++]; [NEW]
org.apache.cassandra.cql3.validation.operations.SelectTest.testListContainsWithIndex: test failed in the recent build. No failures on upstream;
branch story: [F+++] vs upstream: [++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++]; [NEW]
org.apache.cassandra.db.commitlog.GroupCommitLogTest.testHeaderOnlyFileFiltering[2]: test failed in the recent build. No failures on upstream;
branch story: [F+++] vs upstream: [++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++]; [NEW]
org.apache.cassandra.db.VerifyTest.testVerifyRowIndex: test failed in the recent build. No failures on upstream;
branch story: [F+++] vs upstream: [+S+++S+++S+++S+++S+++S+++S+++S+++S+++S+++S+++S+++S+++S+++S++]; [NEW]
org.apache.cassandra.db.NameSortTest.testNameSort100: test failed in the recent build. No failures on upstream;
branch story: [F+++] vs upstream: [++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++]; [NEW]
butler comparison

@michaeljmarshall
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blambov - here are the test results from enabling node awareness by default. I'll review today

@michaeljmarshall
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2417 failures

There were a lot of failures. I think it was due to a faulty rangeSpanned implementation. That's fixed in the next commit.

Please sign in to comment.