Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin API: stream stats-internal with StreamingOutput #249

Open
wants to merge 2 commits into
base: 3.1_ds
Choose a base branch
from
Open

Admin API: stream stats-internal with StreamingOutput #249

wants to merge 2 commits into from

Conversation

eolivelli
Copy link
Collaborator

@eolivelli eolivelli commented Apr 12, 2024 •
edited
Loading

Modifications:

  • use the StreamingOutput API to stream the results of GetInternalStats, as the JSON may be huge when individuallyDeletedMessages inside ManagedLedgerInternalStats$CursorStats contains many ranges
  • this approach is already used in other APIs, so nothing new

@eolivelli eolivelli changed the title Admin API: stream stats - POC do not merge Admin API: stream stats-internal with StreamingOutput Apr 15, 2024
@eolivelli eolivelli marked this pull request as ready for review April 15, 2024 13:00
@eolivelli
Copy link
Collaborator Author

Upstream PR
apache#22510

michaeljmarshall
michaeljmarshall approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@michaeljmarshall michaeljmarshall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljmarshall michaeljmarshall michaeljmarshall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eolivelli @michaeljmarshall