Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: repl improvements #25010

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: repl improvements #25010

wants to merge 1 commit into from

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Aug 12, 2024

Several changes aiming to improve legibility and functionality. Currently WIP pending fixes to LSP completion & additions to rustyline.

Peek.2024-08-12.22-34.mp4

@sigmaSd
Copy link
Contributor

sigmaSd commented Aug 12, 2024

I personally don't like the In Out prompts, I think the current style is nicer.

@jeff-hykin
Copy link

jeff-hykin commented Aug 13, 2024

I'm personally conflicted. I support it, as I think this design is more functional. I can think of plently of times where the extra newline would have helped when pasting multiline inputs. But also I agree it looks less visually appealing compared to the simple prompt right now.

Not to bikeshed, but just to give an option: maybe a symbol for output and a symbol for input, instead of words, would be more appealing. Ex

<1:
>1:

1:
1;

1:
1*

@ry
Copy link
Member

ry commented Aug 16, 2024

Looks great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants