fix(console): never invoke Proxy traps when logging a Proxy #25063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-646
to
-648
| if (proxyDetails !== null && ctx.showProxy) { | ||
| return `Proxy ` + formatValue(ctx, proxyDetails, recurseTimes); | ||
| } else { |
There was a problem hiding this comment.
All this looks like a lot of changes, but I basically only hoisted out this proxyDetails !== null branch and moved it to a few lines above. So it's only indentation changes from here on.
| @@ -2118,30 +2166,6 @@ Deno.test(function inspectProxy() { | |||
| )), | |||
| `{ key: "value" }`, | |||
| ); | |||
| assertEquals( | |||
There was a problem hiding this comment.
Removed this test, because it was asserting that we did invoke proxy traps, even if we shouldn't.
marvinhagemeister
force-pushed
the
proxy-logging
branch
from
bb126fa
to
1b87568
Compare
marvinhagemeister
force-pushed
the
proxy-logging
branch
from
054d2b1
to
cff57ae
Compare
petamoriken
reviewed
Aug 16, 2024
| function createFilteredInspectProxy<TObject>(params: { | ||
| object: TObject; | ||
| keys: (keyof TObject)[]; | ||
| evaluate: boolean; |
There was a problem hiding this comment.
We may need to remain evaluate option to detect if it's an instance object or a prototype object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing
console.log(someProxy)the Proxy traps should never be invoked. We always did invoke them before which lead to unexpected errors. This aligns proxy logging in Deno with all other runtimes.Fixes #25054
Fixes #24980
Fixes #12926