feat: add --open to deno serve to open server in browser #25340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marvinhagemeister @dsherret Is there a workaround or should I just remove the test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue number #25149
Change:
Supported --open flag with deno serve -> (deno serve --open somescript.ts/js).
The action that takes place is openning the browser on the address that the server is running on.
Changes on code:
Concerns:
The window tab will be opened on deno serve command no matter whether deno serve succeeds or fails.
The added test since it's a serve command then it starts listening for a request and never shuts down, I couldn't figure out how to shut it down same as other serve tests.