Vulkan: Don't do MoltenVK things on Asahi Linux #13050
Open
+269
−199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TellowKrinkle
force-pushed
the
HKIsNotMVK
branch
5 times, most recently
from
a14b182
to
09b5b0c
Compare
K0bin
approved these changes
Sep 5, 2024
Previously we'd assume all Apple GPUs were MoltenVK, including those running on Asahi Linux with open source Honeykrisp drivers.
TellowKrinkle
force-pushed
the
HKIsNotMVK
branch
from
09b5b0c
to
dc6ccfb
Compare
Removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honeykrisp (Mesa Vulkan driver for Apple GPUs) is in fact not MoltenVK, and doesn't appreciate being given things that are only accepted by our custom modified MoltenVK
Note: Haven't actually tested this on Apple + MoltenVK yet, will test soonTested, fbfetch seems to be working fine