Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignTool: Use .NET Core MSBuild for Non-Windows #15045

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Sep 4, 2024

Closes #14430

I tested these changes locally by running the unit tests via ./test.sh. For e2e testing, I initially considered configuring a local project to pull the SignTool package from a local feed. While this seems viable, the setup can be tedious. If there's a better method for e2e testing, please let me know.

@mmitche
Copy link
Member

mmitche commented Sep 4, 2024

My favorite method of end 2 end local testing has always been to do the local feed dance. Key points:

  • Arcade repo with changes I build with /p:OfficialBuildId=Date.Rev.
  • Test repo I clone separately
  • Update arcade package in global.json for each test iteration

For actual validation for this, we should augment arcade-validation to:

  • Run -sign in non-Windows PR legs (dry run)

#14431 would cover enabling real signing there.

@ellahathaway
Copy link
Member Author

My favorite method of end 2 end local testing has always been to do the local feed dance. Key points:

  • Arcade repo with changes I build with /p:OfficialBuildId=Date.Rev.
  • Test repo I clone separately
  • Update arcade package in global.json for each test iteration

For actual validation for this, we should augment arcade-validation to:

  • Run -sign in non-Windows PR legs (dry run)

#14431 would cover enabling real signing there.

Awesome thanks for explaining. I'll work on e2e testing and update this PR if changes are needed.

@ellahathaway
Copy link
Member Author

Finished local testing on linux. Build ran as expected and I verified via the binlogs that the tool was using .NET Core msbuild for building MicroBuild.

@ellahathaway ellahathaway merged commit fd7ca2e into dotnet:main Sep 5, 2024
11 checks passed
@ellahathaway ellahathaway deleted the netcore-msbuild branch September 5, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable use of SignTool using .NET Core MSBuild
2 participants