Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#38] Created a campaign example page. #39

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[#38] Created a campaign example page. #39

wants to merge 1 commit into from

Conversation

BrianGilbert
Copy link
Member

Created basic campaign page.

Decipher
Decipher requested changes Oct 15, 2020
View reviewed changes
Copy link
Member

@Decipher Decipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs work.

nuxt.config.js Outdated Show resolved Hide resolved
pages/campaign.vue Outdated Show resolved Hide resolved
pages/campaign.vue Outdated Show resolved Hide resolved
pages/campaign.vue Outdated Show resolved Hide resolved
pages/campaign.vue Outdated Show resolved Hide resolved
@Decipher
Copy link
Member

This can't be committed at the moment as the UUIDs don't match the content.

There are multiple solutions that could be implemented:

  1. Update the UUIDs, but they will break again as the demo backend re-installs itself on deployment
  2. Use queries in fetch to get the UUIDs
  3. Add the ability to use NID's in druxt-entity

Decipher pushed a commit that referenced this pull request Aug 9, 2022
@renovate @renovate-bot
fix(deps): update dependency composer/installers to v2 (#39)
926fa44 
Co-authored-by: Renovate Bot <[email protected]>
@Decipher Decipher force-pushed the develop branch 3 times, most recently from 4326111 to 8bddb4a Compare September 14, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Decipher Decipher Decipher requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrianGilbert @Decipher