Implement single-value removal #4
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's some annoying problems that still need to be resolved here. Basically, removal can leave the tree in an invalid state (maybe?), and we need to be really careful about making sure that either: (a) panics during invalid states don't cause memory issues, or (b) operations that can panic are only called during valid states Both are tricky -- not sure which one is better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR currently represents partial progress. Single-value removal is basically required to finish the remaining bits of the insertion implementation (i.e.,
handle_join_deletion).There's some annoying problems that still need to be resolved here. Basically, removal can leave the tree in an invalid state (maybe?), and we need to be really careful about making sure that either:
Both are tricky -- not sure which one is better yet.