Connection pool optimization: reduce connection maintenance loops complexity #929
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a small low hanging fruit for optimizing and simplifying the connection maintenance loops in the connection pool. This work is based on suggestion by @T-256 here (thanks!). Previously performance of
httpcore
degraded as connection count increased in the pool. As the maintenance loops had to do more and more work iterating and reiterating the connections.This optimization brings the performance of
httpcore
to same level asurllib3
with sync-usage.The benchmarks below include the socket polling fix. (The socket polling problem makes request processing latency so highly varying that it overshadows everything.)
Previously with sync (with optimized socket polling):
PR with sync:
As it can be seen the performance gets to exact same level as
urllib3
. There is almost no overhead fromhttpcore
related request processing anymore.Checklist