Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: upload progress #2725

Merged
merged 12 commits into from
Jul 13, 2023
Merged

docs: upload progress #2725

merged 12 commits into from
Jul 13, 2023

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented May 30, 2023

Summary

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Kludex
Copy link
Sponsor Member

Kludex commented May 30, 2023

Should we just include a blog post about it instead of including in the docs?

@tomchristie
Copy link
Member

Should we just include a blog post about it instead of including in the docs?

Valid question. Seems reasonable to include it in the docs seeing as we've got download tracking examples?

Aside: The other kind of upload tracking would be tracking multipart file uploads. Exercise for the reader.

@trim21
Copy link
Contributor Author

trim21 commented Jun 10, 2023

Seems reasonable to include it in the docs seeing as we've got download tracking examples?

Why I submit this pr

docs/advanced.md Outdated Show resolved Hide resolved
docs/advanced.md Outdated Show resolved Hide resolved
@trim21
Copy link
Contributor Author

trim21 commented Jul 7, 2023

@tomchristie Any more suggestion?

Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me.
Walrus, so only works with 3.8+ but that's probs okay.
httpbin takes a long time to return the response from that endpoint which is a bit confusing when running the sample, but again probably fine.

@trim21
Copy link
Contributor Author

trim21 commented Jul 7, 2023

Walrus, so only works with 3.8+ but that's probs okay.

python 3.7 reached its EOL 2 weeks ago...

@trim21
Copy link
Contributor Author

trim21 commented Jul 13, 2023

Looks pretty good to me. Walrus, so only works with 3.8+ but that's probs okay. httpbin takes a long time to return the response from that endpoint which is a bit confusing when running the sample, but again probably fine.

So any progress?

@tomchristie
Copy link
Member

We okay with this @encode/maintainers?

(Hit merge if ya think so I guess)

docs/advanced.md Outdated Show resolved Hide resolved
Co-authored-by: Kar Petrosyan <[email protected]>
@karpetrosyan
Copy link
Member

Great!

@karpetrosyan karpetrosyan merged commit f115ce4 into encode:master Jul 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants