-
-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: upload progress #2725
docs: upload progress #2725
Conversation
Should we just include a blog post about it instead of including in the docs? |
Valid question. Seems reasonable to include it in the docs seeing as we've got download tracking examples? Aside: The other kind of upload tracking would be tracking multipart file uploads. Exercise for the reader. |
Why I submit this pr |
@tomchristie Any more suggestion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me.
Walrus, so only works with 3.8+ but that's probs okay.
httpbin
takes a long time to return the response from that endpoint which is a bit confusing when running the sample, but again probably fine.
python 3.7 reached its EOL 2 weeks ago... |
So any progress? |
We okay with this @encode/maintainers? (Hit merge if ya think so I guess) |
Co-authored-by: Kar Petrosyan <[email protected]>
Great! |
Summary
Checklist