-
-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support request.url_for in BaseMiddleware #2672
base: master
Are you sure you want to change the base?
Conversation
url_pather: Starlette | Router = self.scope.get("app") or self.scope["router"] | ||
url_path = url_pather.url_path_for(name, **path_params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed to fall back to using scope["router"]
to support the case where a Router
is directly fed to a TestClient
, as happens in test_routing.py
.
if request.url == request.url_for("special"): | ||
return PlainTextResponse("Special") | ||
return await call_next(request) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shows the main motivation for supporting request.url_for()
before call_next
: it allows you to handle authentication or other concerns differently depending on the URL without hardcoding paths or path prefixes.
Well, actually this is not only for |
70e77e2
to
c80f9be
Compare
@Kludex Let me know if you'd like the commit message changed or anything, that's no problem. Otherwise, it's rebased and ready if you're interested in the change. |
Summary
Resolve the bug (or limitation) in this related discussion where
Request.url_for()
cannot be called in a middleware inheriting fromBaseHTTPMiddleware
before theRouter
/call_next
is invoked.Checklist