Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use tailwind instead of inline styles #3353

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

a-3140
Copy link
Contributor

@a-3140 a-3140 commented Apr 19, 2023

Some notable changes that aren't 1:1 from inline styles to tailwind usage:

  1. From padding-x: 30px -> px-8 ( px-8 is 32px )
  2. height: 300px -> h-72 which is 288px
  3. height: 120px -> h-32 which is 128px

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@m0ksem
Copy link
Collaborator

m0ksem commented Apr 28, 2023

Some notable changes that aren't 1:1 from inline styles to tailwind usage:

From padding-x: 30px -> px-8 ( px-8 is 32px )
height: 300px -> h-72 which is 288px
height: 120px -> h-32 which is 128px

It is OK. Thanks!

@a-3140
Copy link
Contributor Author

a-3140 commented May 1, 2023

Gotcha, will sync them all up.. :)

@a-3140
Copy link
Contributor Author

a-3140 commented May 29, 2023

I've been caught up with work.. will be able to finish this within the week.. I hope that's okay.. thanks.

@m0ksem
Copy link
Collaborator

m0ksem commented May 31, 2023

I've been caught up with work.. will be able to finish this within the week.. I hope that's okay.. thanks.

Hi @a-3140. In case you are busy, we have another PR fixing this problem. I suggest finish some work in ui-elements folder, so @xiongmao86 can work on another sections (btw, he already did some work on another sections like services, ag-grid etc.)

@a-3140 a-3140 changed the title chore: Use tailwind instead of inline styles ( WIP ) chore: Use tailwind instead of inline styles Jun 18, 2023
@a-3140
Copy link
Contributor Author

a-3140 commented Jun 18, 2023

Apologies @m0ksem , took a while as I started on a new company and focused there on a bit..

I finished the MR now, it should be on top of the separate changes regarding the usage of tailwind. For notes on changes of couple of pixels, it's included in the description..

I'll mark it as ready for review now.. thanks.

@a-3140 a-3140 marked this pull request as ready for review June 18, 2023 08:27
@@ -12,7 +12,8 @@
/>
<va-breadcrumbs-item label="Four" />
<va-breadcrumbs-item label="Five">
<span style="font-style: italic; color: var(--va-danger);">Slotted content</span>
<span class="italic text-[var(--va-danger)]">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m0ksem, double check if text-[var(--va-danger)] can be replaced with text-danger.

@m0ksem m0ksem added the docs packages/docs label Jun 19, 2023
@m0ksem m0ksem requested a review from asvae June 19, 2023 22:34
@m0ksem
Copy link
Collaborator

m0ksem commented Jun 19, 2023

@asvae, I did a QA. Looks solid, can be merged.

Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked several pages. Things look all right!

@asvae asvae merged commit a6795a8 into epicmaxco:develop Jun 20, 2023
2 checks passed
@a-3140
Copy link
Contributor Author

a-3140 commented Jun 25, 2023

Awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs packages/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants