Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve dynamic bundler infrastructure, create @docusaurus/bundler package #10511

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Sep 19, 2024

Motivation

Improve codebase in preparation for introducing opt-in Rspack support (#10402)

Abstract Webpack/Rspack bundler code that diverges under a new @docusaurus/bundler package.

Note: we can't keep all this code in core because we use some of these methods in the PWA plugin (notably the progress bar plugin) so we need it to be moved to a separate package. Maybe exposing this abstraction could also be useful for the community 🤷‍♂️ although we'll first consider it an internal implementation detail.

Test Plan

CI + preview

Test links

https://deploy-preview-10511--docusaurus-2.netlify.app/

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Sep 19, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 19, 2024
Copy link

socket-security bot commented Sep 19, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Copy link

netlify bot commented Sep 19, 2024

[V2]

Name Link
🔨 Latest commit a3a33d9
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66ec44f4e96ad100083931e7
😎 Deploy Preview https://deploy-preview-10511--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Sep 19, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 72 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 55 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 74 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 61 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 47 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 64 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟠 86 Report

@slorber slorber added the Argos Add this label to run UI visual regression tests. See argos.yml GH action. label Sep 19, 2024
Copy link

argos-ci bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Sep 19, 2024, 3:43 PM

Copy link

Report too large to display inline

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants