Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New parameter added in order to replace negative predictions with 0 #2610

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mrtergl
Copy link

@mrtergl mrtergl commented Aug 17, 2024

Sometimes, data series contain many values close to zero but are not expected to fall below zero. For example, a data frame with response times will likely have many near-zero values. In such cases, Prophet may produce yhat_lower or trend_lower metric values that are negative.

To address this issue, I have implemented a flag that sets all negative values to zero in the data frame. This flag can be configured when defining the model.

@facebook-github-bot
Copy link
Contributor

Hi @mrtergl!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@mrtergl
Copy link
Author

mrtergl commented Aug 18, 2024

This improvement can solve issue #2471

@mrtergl
Copy link
Author

mrtergl commented Aug 22, 2024

Hey @tcuongd , could you please review my pull request?

@donggu-kang
Copy link

I think this pull request is useful.

I am currently using Prophet for various purposes.
One of them is to predict traffic trends/detect anomalies.

I currently use it as a code to replace negative values ​​with 0 in the post-processing process.

Because even if I do not train Prophet with values ​​less than 0, there were cases where the prediction result was predicted as a negative number less than 0.

So I personally think this suggestion can be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants