-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not hold raw RuntimeScheduler pointer in BufferedRuntimeExecutor #46542
Open
javache
wants to merge
2
commits into
facebook:main
Choose a base branch
from
javache:export-D62748768
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
fb-exported
labels
Sep 17, 2024
This pull request was exported from Phabricator. Differential Revision: D62748768 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D62748768 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 18, 2024
…acebook#46542) Summary: Pull Request resolved: facebook#46542 If `bufferedRuntimeExecutor_` is referenced beyond the lifetime of the ReactInstance, it may point to invalid memory. RuntimeScheduler already holds weak references to the actual runtime, so it's safe to retain that instead. Changelog: [Internal] Reviewed By: rshest Differential Revision: D62748768
javache
force-pushed
the
export-D62748768
branch
from
September 18, 2024 12:01
059132a
to
6200771
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 18, 2024
…acebook#46542) Summary: Pull Request resolved: facebook#46542 If `bufferedRuntimeExecutor_` is referenced beyond the lifetime of the ReactInstance, it may point to invalid memory. RuntimeScheduler already holds weak references to the actual runtime, so it's safe to retain that instead. Changelog: [Internal] Differential Revision: D62748768 Reviewed By: rshest
…46544) Summary: Pull Request resolved: facebook#46544 Experiments with `completeReactInstanceCreationOnBgThreadOnAndroid` have shown a native crash in this code path, but it also existed previously. I believe this is due to the ordering of ReactInstance teardown: we first destroy the ReactInstance, and only then destroy the reference to it in mCreateReactInstanceTaskRef. When using the immediate executor and completeReactInstanceCreationOnBgThreadOnAndroid, we read the react instance from the task, which may no longer be valid at this point. Resetting the task at the earliest point should mitigate the issue. Changelog: [Internal] Differential Revision: D62872625 Reviewed By: markv
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 19, 2024
…acebook#46542) Summary: Pull Request resolved: facebook#46542 If `bufferedRuntimeExecutor_` is referenced beyond the lifetime of the ReactInstance, it may point to invalid memory. RuntimeScheduler already holds weak references to the actual runtime, so it's safe to retain that instead. Changelog: [Internal] Differential Revision: D62748768 Reviewed By: rshest
…acebook#46542) Summary: Pull Request resolved: facebook#46542 If `bufferedRuntimeExecutor_` is referenced beyond the lifetime of the ReactInstance, it may point to invalid memory. RuntimeScheduler already holds weak references to the actual runtime, so it's safe to retain that instead. Changelog: [Internal] Reviewed By: rshest Differential Revision: D62748768
This pull request was exported from Phabricator. Differential Revision: D62748768 |
javache
force-pushed
the
export-D62748768
branch
from
September 19, 2024 13:08
6200771
to
66ef74d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
If
bufferedRuntimeExecutor_
is referenced beyond the lifetime of the ReactInstance, it may point to invalid memory. RuntimeScheduler already holds weak references to the actual runtime, so it's safe to retain that instead.Changelog: [Internal]
Differential Revision: D62748768