Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Component.js #87

Merged
merged 2 commits into from
Feb 5, 2013
Merged

Add support for Component.js #87

merged 2 commits into from
Feb 5, 2013

Conversation

djanowski
Copy link
Contributor

As discussed in #85.

@djanowski
Copy link
Contributor Author

Sorry, ./component.json needs to be versioned as well, I'll change that now.

@djanowski
Copy link
Contributor Author

@rvagg Done, component.json is automatically generated out of package.json on make.

@djanowski
Copy link
Contributor Author

@rvagg Let me know if this sounds okay, otherwise I can maintain a fork.

@djanowski
Copy link
Contributor Author

(But for Component's default ranking of repositories, it'd be nice if we stayed on the canonical repo.)

@rvagg
Copy link
Collaborator

rvagg commented Feb 5, 2013

Sorry @djanowski, this fell off my radar. I'm more than happy to include this, but, perhaps it'd be best to do the component.json build under boosh:, that way it'll be sure to be updated whenever we push a new version. Does that make sense? It'd be nice if I didn't have to remember to make components each time.

@djanowski
Copy link
Contributor Author

@rvagg Actually, that was the intention. Is components not getting run when you make? I created the build task just for the sake of tidiness, but if you guys use make boosh explicitly, then I'll make components a dependency of it.

@rvagg rvagg merged commit c165396 into fat:master Feb 5, 2013
@rvagg
Copy link
Collaborator

rvagg commented Feb 5, 2013

Sorry, didn't notice you put it as a dependency to the main task! Merged but I've pulled out component_json to a separate task so I you don't get a failure when you don't have component installed. All good now? Do I need to git tag the latest for this to work?

@djanowski
Copy link
Contributor Author

Nope, everything works now. I already added the repo to Component's wiki. :-) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants