Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(release): fix hardcoded profile #8888

Merged
merged 3 commits into from
Sep 18, 2024
Merged

ci(release): fix hardcoded profile #8888

merged 3 commits into from
Sep 18, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Sep 18, 2024 •
edited
Loading

@DaniPopes DaniPopes enabled auto-merge (squash) September 18, 2024 07:53
zerosnacks
zerosnacks approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Difficult to test locally but proposed changes LGTM

@mattsse
Copy link
Member

mattsse commented Sep 18, 2024

smol conflict

@DaniPopes DaniPopes merged commit 08f1a07 into master Sep 18, 2024
20 checks passed
@DaniPopes DaniPopes deleted the dani/release-ci-vars branch September 18, 2024 14:10
@zerosnacks zerosnacks mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@zerosnacks zerosnacks zerosnacks approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: release workflow failed
3 participants
@DaniPopes @mattsse @zerosnacks