fix(wgpu): Raise validation error instead of panicking in get_bind_group_layout. #6280
+222
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just saw that the PR is still marked as WIP, are there other changes you are planning to make? |
|
There were documentation changes I wanted to make. Also I need to update CHANGELOG. I ran out of time before I put up the PR. I have more time now, I'll update the PR. |
…oup_layout. Fixes gfx-rs#4167.
Also reorganize some changelog entries that were in the wrong place.
BGR360
force-pushed
the
issue-4167-validate-bgl
branch
from
9ce0403
to
2784795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #4167.
Depends on #6275.
Description
Testing
I've removed the expect-fail decoration from the existing test added in #4168, and added three more tests to cover the remaining cases.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.