Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes mention of only supporting Pageant #172

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jkelroy
Copy link
Contributor

@jkelroy jkelroy commented Sep 20, 2023

I did a quick review of this page and did not see anything else outdated besides the following, which still may be partially true still. Should we leave this in for now until we fully migrate?

  • Expected use of SSH config — GitKraken Client does not currently respect your SSH config and cannot make use of any remote server nicknames or identities.
    • You can either load your SSH key directly into GitKraken Client or use your system’s SSH agent to authenticate with your remote.

@ianhattendorf
Copy link
Contributor

Should we leave this in for now until we fully migrate?

Let's leave it for now, I'm not 100% sure which portions of the SSH config GitKraken will respect. It should respect almost all of it when Use local SSH agent is checked, but when using integration/profile keys I'm not sure without thinking about it more.

Copy link
Contributor

@ianhattendorf ianhattendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, actually we might need to leave this for now. Clone for example is still on NodeGit only, so will only work with Putty over SSH. Unless that's no longer the case for and we support the built-in SSH for NodeGit as well? @relyss do you know if that's the case?

@relyss
Copy link

relyss commented Sep 21, 2023

I've tried cloning an SSH URL with Local agent set up for OpenSSH and it worked fine 👍
I also confirmed that for Git bundled / scm it's working both for bundled and external OpenSSH (chosen during Git installation), as long as the keys are correctly setup and the agent is running, I'm using the one that comes preinstalled in Windows.
Although like you said, it's using Nodegit so it's a bit irrelevant.

@jkelroy
Copy link
Contributor Author

jkelroy commented Jul 26, 2024

@ianhattendorf @relyss I believe all remote actions are now using Git Executable correct? If so, can we remove the mention of only supporting Pageant now?

CC @vicenter-gitkraken

@ianhattendorf
Copy link
Contributor

@ianhattendorf @relyss I believe all remote actions are now using Git Executable correct? If so, can we remove the mention of only supporting Pageant now?

CC @vicenter-gitkraken

There are still places that use NodeGit for remotes, mostly tied to launchpad, submodules, and remote management IIRC. It's just the most common ones that have been converted.

/cc @julianmesa-gitkraken @AlexaXs to confirm, as they've been working on scoping out the last of the migration recently

@AlexaXs
Copy link

AlexaXs commented Aug 2, 2024

@ianhattendorf @relyss I believe all remote actions are now using Git Executable correct? If so, can we remove the mention of only supporting Pageant now?
CC @vicenter-gitkraken

There are still places that use NodeGit for remotes, mostly tied to launchpad, submodules, and remote management IIRC. It's just the most common ones that have been converted.

/cc @julianmesa-gitkraken @AlexaXs to confirm, as they've been working on scoping out the last of the migration recently

True, we are still using NodeGit credentials (See trace in remaining work to remove NodeGit.Cred down from getRemoteOptions) for some cases as Ian says (submodules, adding first remote of a new local repo, and other cases). What we are not sure about is that NodeGit for remote credentials on Windows only supports pageant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants