Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make elm a peer dependency. #587

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

0x450x6c
Copy link

@0x450x6c 0x450x6c commented Apr 3, 2021

Background: #370

Also, made it so that elm and elm-test will be taken from PATH when possible, it makes possible to use this project with node2nix.

@0x450x6c 0x450x6c force-pushed the master branch 4 times, most recently from 124455b to e625173 Compare April 3, 2021 12:35
@0x450x6c 0x450x6c changed the title Make elm a peer dependency. WIP: Make elm a peer dependency. Apr 3, 2021
@0x450x6c 0x450x6c force-pushed the master branch 25 times, most recently from 0c0aee5 to a240b48 Compare April 3, 2021 15:18
@0x450x6c 0x450x6c force-pushed the master branch 12 times, most recently from cfb4263 to d077034 Compare April 3, 2021 21:39
@0x450x6c 0x450x6c changed the title WIP: Make elm a peer dependency. Make elm a peer dependency. Apr 3, 2021
@@ -1,4 +1,4 @@
image: Visual Studio 2017
image: Visual Studio 2019
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build fails in the old windows, but I haven't such OS to debug, hope someone else can help with that.

https://ci.appveyor.com/project/halfzebra/create-elm-app/builds/38540133/job/7duw5ityiktqj1wf

@nicklayb
Copy link

I'd love this to be merged, I'm having hiccups trying to install create-elm-app in a docker container on a M2 mac as it still tries to install elm even I installed it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants