Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous updates #34

Merged
merged 8 commits into from
May 1, 2024
Merged

Miscellaneous updates #34

merged 8 commits into from
May 1, 2024

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Apr 23, 2024

This PR proposes the following changes:

  • Update GitHub Actions versions
  • Use go install to install the command
  • Migrate from deprecated package io/ioutil
  • Migrate from interface{} to any
  • Omit unnecessary break statement
  • Return values directly

@0xmks 0xmks self-requested a review April 26, 2024 05:57
0xmks
0xmks approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@0xmks 0xmks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you!

@0xmks 0xmks merged commit 960a998 into hatena:master May 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmks 0xmks 0xmks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itchyny @0xmks