Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Refactor Msg class" #626

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stefanu21
Copy link

This reverts commit c0f9d53.

This is a break in the api. Projects like icemon no longer works.

This reverts commit c0f9d53.
@ossilator
Copy link
Contributor

this feels very wrong to me.
instead, the internal api should be properly versioned, and icemon (the only external consumer?) should have the required #ifdefs.

@stefanu21
Copy link
Author

yes you are right but the mistake has already happened that the api is not versioned correctly. nevertheless there is no compelling reason to change the api like this and make the clients unusable. after all, this is just cosmetics. if it would be about projects that would be developed much further ok but neither icecc nor icemon has done anything substantial in the last years except the new scheduler modis...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants