Validate Gradle Wrapper

Refactor device memory implementation to make it more generic #1476

Triggered via push September 19, 2024 20:25

javier-intel

pushed 7258747

generic_device_memory

Status Success

Total duration 25s

Artifacts –

gradle-wrapper-validation.yml

on: push

Validation

16s

Annotations

2 warnings and 101 notices

[shellcheck] tools/ci_build/github/linux/build_linux_python_package.sh#L53 <ShellCheck.SC2001>: tools/ci_build/github/linux/build_linux_python_package.sh#L53

See if you can use ${variable//search/replace} instead.

[shellcheck] tools/ci_build/github/linux/build_linux_python_package.sh#L53 <ShellCheck.SC2086>: tools/ci_build/github/linux/build_linux_python_package.sh#L53

Double quote to prevent globbing and word splitting.

[cpplint] onnxruntime/contrib_ops/cpu/bert/gqa_attention_base.h#L120: onnxruntime/contrib_ops/cpu/bert/gqa_attention_base.h#L120

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/contrib_ops/cpu/bert/gqa_attention_base.h#L251: onnxruntime/contrib_ops/cpu/bert/gqa_attention_base.h#L251

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/contrib_ops/cpu/bert/group_query_attention.cc#L127: onnxruntime/contrib_ops/cpu/bert/group_query_attention.cc#L127

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L240: onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L240

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L243: onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L243

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L386: onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L386

Using C-style cast. Use static_cast<size_t>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L389: onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L389

Using C-style cast. Use static_cast<size_t>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L390: onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L390

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L518: onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L518

Using C-style cast. Use static_cast<size_t>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L521: onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L521

Using C-style cast. Use static_cast<size_t>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L537: onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L537

Using C-style cast. Use static_cast<size_t>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L538: onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L538

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L599: onnxruntime/contrib_ops/cpu/quantization/matmul_nbits.cc#L599

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/contrib_ops/cpu/quantization/matmul_nbits_impl.cc#L62: onnxruntime/contrib_ops/cpu/quantization/matmul_nbits_impl.cc#L62

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/contrib_ops/cuda/bert/group_query_attention_impl.cu#L369: onnxruntime/contrib_ops/cuda/bert/group_query_attention_impl.cu#L369

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/contrib_ops/cuda/bert/group_query_attention_impl.cu#L533: onnxruntime/contrib_ops/cuda/bert/group_query_attention_impl.cu#L533

Add #include <algorithm> for min [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/optimizer/transpose_optimization/onnx_transpose_optimization.cc#L139: onnxruntime/core/optimizer/transpose_optimization/onnx_transpose_optimization.cc#L139

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/optimizer/transpose_optimization/onnx_transpose_optimization.cc#L173: onnxruntime/core/optimizer/transpose_optimization/onnx_transpose_optimization.cc#L173

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/optimizer/transpose_optimization/optimizer_api.h#L375: onnxruntime/core/optimizer/transpose_optimization/optimizer_api.h#L375

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/optimizer/transpose_optimization/ort_optimizer_api_impl.cc#L141: onnxruntime/core/optimizer/transpose_optimization/ort_optimizer_api_impl.cc#L141

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/acl/acl_common.cc#L155: onnxruntime/core/providers/acl/acl_common.cc#L155

Using C-style cast. Use reinterpret_cast<uint8_t*>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/core/providers/acl/acl_common.cc#L91: onnxruntime/core/providers/acl/acl_common.cc#L91

Add #include <string> for string [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/acl_common.cc#L142: onnxruntime/core/providers/acl/acl_common.cc#L142

Add #include <algorithm> for max [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/acl_common.cc#L152: onnxruntime/core/providers/acl/acl_common.cc#L152

Add #include <memory> for unique_ptr<> [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/acl_common.cc#L152: onnxruntime/core/providers/acl/acl_common.cc#L152

Add #include <vector> for vector<> [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/acl_common.h#L31: onnxruntime/core/providers/acl/acl_common.h#L31

Add #include <string> for string [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/acl_common.h#L38: onnxruntime/core/providers/acl/acl_common.h#L38

Add #include <memory> for unique_ptr<> [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/acl_common.h#L38: onnxruntime/core/providers/acl/acl_common.h#L38

Add #include <vector> for vector<> [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/acl_execution_provider.cc#L16: onnxruntime/core/providers/acl/acl_execution_provider.cc#L16

Include the directory when naming header files [build/include_subdir] [4]

[cpplint] onnxruntime/core/providers/acl/acl_execution_provider.cc#L76: onnxruntime/core/providers/acl/acl_execution_provider.cc#L76

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/acl/acl_execution_provider.cc#L98: onnxruntime/core/providers/acl/acl_execution_provider.cc#L98

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/acl/acl_execution_provider.cc#L101: onnxruntime/core/providers/acl/acl_execution_provider.cc#L101

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/acl/acl_execution_provider.cc#L103: onnxruntime/core/providers/acl/acl_execution_provider.cc#L103

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/acl/acl_execution_provider.cc#L104: onnxruntime/core/providers/acl/acl_execution_provider.cc#L104

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/acl/acl_execution_provider.cc#L106: onnxruntime/core/providers/acl/acl_execution_provider.cc#L106

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/acl/acl_execution_provider.cc#L107: onnxruntime/core/providers/acl/acl_execution_provider.cc#L107

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/acl/acl_execution_provider.cc#L109: onnxruntime/core/providers/acl/acl_execution_provider.cc#L109

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/acl/acl_execution_provider.cc#L110: onnxruntime/core/providers/acl/acl_execution_provider.cc#L110

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/acl/acl_execution_provider.cc#L189: onnxruntime/core/providers/acl/acl_execution_provider.cc#L189

You don't need a ; after a } [readability/braces] [4]

[cpplint] onnxruntime/core/providers/acl/acl_execution_provider.cc#L194: onnxruntime/core/providers/acl/acl_execution_provider.cc#L194

You don't need a ; after a } [readability/braces] [4]

[cpplint] onnxruntime/core/providers/acl/acl_execution_provider.cc#L156: onnxruntime/core/providers/acl/acl_execution_provider.cc#L156

Add #include <vector> for vector<> [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/acl_execution_provider.cc#L161: onnxruntime/core/providers/acl/acl_execution_provider.cc#L161

Add #include <string> for string [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/acl_execution_provider.cc#L173: onnxruntime/core/providers/acl/acl_execution_provider.cc#L173

Add #include <memory> for make_unique<> [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/acl_execution_provider.cc#L173: onnxruntime/core/providers/acl/acl_execution_provider.cc#L173

Add #include <utility> for move [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/acl_execution_provider.h#L39: onnxruntime/core/providers/acl/acl_execution_provider.h#L39

Add #include <vector> for vector<> [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/acl_execution_provider.h#L56: onnxruntime/core/providers/acl/acl_execution_provider.h#L56

Add #include <memory> for shared_ptr<> [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/acl_provider_factory.cc#L15: onnxruntime/core/providers/acl/acl_provider_factory.cc#L15

Single-parameter constructors should be marked explicit. [runtime/explicit] [5]

[cpplint] onnxruntime/core/providers/acl/math/gemm.h#L138: onnxruntime/core/providers/acl/math/gemm.h#L138

Add #include <memory> for make_shared<> [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/math/matmul.cc#L13: onnxruntime/core/providers/acl/math/matmul.cc#L13

<thread> is an unapproved C++11 header. [build/c++11] [5]

[cpplint] onnxruntime/core/providers/acl/math/matmul.cc#L14: onnxruntime/core/providers/acl/math/matmul.cc#L14

<mutex> is an unapproved C++11 header. [build/c++11] [5]

[cpplint] onnxruntime/core/providers/acl/math/matmul.cc#L220: onnxruntime/core/providers/acl/math/matmul.cc#L220

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/acl/math/matmul.cc#L233: onnxruntime/core/providers/acl/math/matmul.cc#L233

Using C-style cast. Use reinterpret_cast<uint8_t*>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/core/providers/acl/math/matmul.cc#L235: onnxruntime/core/providers/acl/math/matmul.cc#L235

Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/core/providers/acl/math/matmul.cc#L283: onnxruntime/core/providers/acl/math/matmul.cc#L283

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/acl/math/matmul.cc#L308: onnxruntime/core/providers/acl/math/matmul.cc#L308

Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/core/providers/acl/math/matmul.cc#L311: onnxruntime/core/providers/acl/math/matmul.cc#L311

Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/core/providers/acl/math/matmul.cc#L315: onnxruntime/core/providers/acl/math/matmul.cc#L315

Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/core/providers/acl/math/matmul.cc#L247: onnxruntime/core/providers/acl/math/matmul.cc#L247

Add #include <utility> for move [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/math/matmul.cc#L271: onnxruntime/core/providers/acl/math/matmul.cc#L271

Add #include <vector> for vector<> [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/math/matmul.h#L13: onnxruntime/core/providers/acl/math/matmul.h#L13

"arm_compute/runtime/Tensor.h" already included at onnxruntime/core/providers/acl/math/matmul.h:10 [build/include] [4]

[cpplint] onnxruntime/core/providers/acl/math/matmul.h#L36: onnxruntime/core/providers/acl/math/matmul.h#L36

Add #include <vector> for vector<> [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/math/matmul.h#L57: onnxruntime/core/providers/acl/math/matmul.h#L57

Add #include <memory> for shared_ptr<> [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/nn/conv.cc#L65: onnxruntime/core/providers/acl/nn/conv.cc#L65

Using C-style cast. Use static_cast<bool>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/core/providers/acl/nn/conv.cc#L127: onnxruntime/core/providers/acl/nn/conv.cc#L127

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/acl/nn/conv.cc#L144: onnxruntime/core/providers/acl/nn/conv.cc#L144

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/acl/nn/conv.cc#L160: onnxruntime/core/providers/acl/nn/conv.cc#L160

Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/core/providers/acl/nn/conv.cc#L233: onnxruntime/core/providers/acl/nn/conv.cc#L233

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/acl/nn/conv.cc#L267: onnxruntime/core/providers/acl/nn/conv.cc#L267

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/acl/nn/conv.cc#L276: onnxruntime/core/providers/acl/nn/conv.cc#L276

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/acl/nn/conv.cc#L286: onnxruntime/core/providers/acl/nn/conv.cc#L286

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/acl/nn/conv.cc#L291: onnxruntime/core/providers/acl/nn/conv.cc#L291

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/acl/nn/conv.cc#L339: onnxruntime/core/providers/acl/nn/conv.cc#L339

Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/core/providers/acl/nn/conv.cc#L348: onnxruntime/core/providers/acl/nn/conv.cc#L348

Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/core/providers/acl/nn/conv.cc#L402: onnxruntime/core/providers/acl/nn/conv.cc#L402

Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/core/providers/acl/nn/conv.cc#L406: onnxruntime/core/providers/acl/nn/conv.cc#L406

Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/core/providers/acl/nn/conv.cc#L45: onnxruntime/core/providers/acl/nn/conv.cc#L45

Add #include <string> for string [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/nn/conv.cc#L319: onnxruntime/core/providers/acl/nn/conv.cc#L319

Add #include <utility> for move [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/nn/conv.cc#L361: onnxruntime/core/providers/acl/nn/conv.cc#L361

Add #include <memory> for unique_ptr<> [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/nn/conv.cc#L372: onnxruntime/core/providers/acl/nn/conv.cc#L372

Add #include <vector> for vector<> [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/nn/conv.h#L16: onnxruntime/core/providers/acl/nn/conv.h#L16

"arm_compute/runtime/Tensor.h" already included at onnxruntime/core/providers/acl/nn/conv.h:13 [build/include] [4]

[cpplint] onnxruntime/core/providers/acl/nn/conv.h#L38: onnxruntime/core/providers/acl/nn/conv.h#L38

Add #include <vector> for vector<> [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/nn/conv.h#L61: onnxruntime/core/providers/acl/nn/conv.h#L61

Add #include <memory> for shared_ptr<> [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/scheduler.cc#L5: onnxruntime/core/providers/acl/scheduler.cc#L5

Include the directory when naming header files [build/include_subdir] [4]

[cpplint] onnxruntime/core/providers/acl/scheduler.cc#L38: onnxruntime/core/providers/acl/scheduler.cc#L38

Using C-style cast. Use static_cast<int>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/core/providers/acl/scheduler.cc#L34: onnxruntime/core/providers/acl/scheduler.cc#L34

Add #include <vector> for vector<> [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/acl/scheduler.h#L4: onnxruntime/core/providers/acl/scheduler.h#L4

Include the directory when naming header files [build/include_subdir] [4]

[cpplint] onnxruntime/core/providers/acl/scheduler.h#L14: onnxruntime/core/providers/acl/scheduler.h#L14

Single-parameter constructors should be marked explicit. [runtime/explicit] [5]

[cpplint] onnxruntime/core/providers/acl/scheduler.h#L26: onnxruntime/core/providers/acl/scheduler.h#L26

Add #include <vector> for vector<> [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/cpu/math/cumsum.cc#L176: onnxruntime/core/providers/cpu/math/cumsum.cc#L176

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/cpu/math/cumsum.cc#L178: onnxruntime/core/providers/cpu/math/cumsum.cc#L178

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/cpu/ml/tree_ensemble_aggregator.h#L334: onnxruntime/core/providers/cpu/ml/tree_ensemble_aggregator.h#L334

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc#L2265: onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc#L2265

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/vitisai/imp/tensor_proto.cc#L29: onnxruntime/core/providers/vitisai/imp/tensor_proto.cc#L29

Using C-style cast. Use static_cast<size_t>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/core/providers/webnn/builders/helper.cc#L169: onnxruntime/core/providers/webnn/builders/helper.cc#L169

Add #include <string> for string [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/webnn/builders/helper.h#L285: onnxruntime/core/providers/webnn/builders/helper.h#L285

Add #include <string> for string [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/webnn/builders/impl/qdq_op_builder.cc#L132: onnxruntime/core/providers/webnn/builders/impl/qdq_op_builder.cc#L132

Lines should be <= 120 characters long [whitespace/line_length] [2]

[cpplint] onnxruntime/core/providers/webnn/builders/impl/qdq_op_builder.cc#L140: onnxruntime/core/providers/webnn/builders/impl/qdq_op_builder.cc#L140

{ should almost always be at the end of the previous line [whitespace/braces] [4]

[cpplint] onnxruntime/core/providers/webnn/builders/model_builder.cc#L103: onnxruntime/core/providers/webnn/builders/model_builder.cc#L103

Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]

[cpplint] onnxruntime/core/providers/xnnpack/xnnpack_kernel.h#L60: onnxruntime/core/providers/xnnpack/xnnpack_kernel.h#L60

Add #include <memory> for unique_ptr<> [build/include_what_you_use] [4]

Validation

This job uses deprecated functionality from the 'gradle/wrapper-validation-action' action. Consult the logs for more details.

[shellcheck] tools/ci_build/github/linux/build_linux_python_package.sh#L18 <ShellCheck.SC2178>: tools/ci_build/github/linux/build_linux_python_package.sh#L18

Variable was used as an array but is now assigned a string.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor device memory implementation to make it more generic #1476

Summary