Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add a section on custom svg paths #1368

Merged
merged 2 commits into from
May 1, 2024

Conversation

christian-bromann
Copy link
Member

In #1302 a user reported an issue experiencing issues loading Ionicons from a custom source. This patch adds a section on how to set a custom resource path through Stencil.

Note: the reported issue used a specific way to integrate ionicons via the @ionic/angular/standalone package. For folks just using an ionicon script tag as described in the readme, this won't be much useful. The added documentation requires the user to use a compiler that resolves the Ionicon and application code with the same resolver.

An alternative would be to add these docs to the @ionic/angular package, please advise!

Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions, non-blocking.

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@christian-bromann
Copy link
Member Author

@liamdebeasi @sean-perkins thanks for the feedback. Added changes accordingly.

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@liamdebeasi liamdebeasi merged commit 06a995e into ionic-team:main May 1, 2024
6 checks passed
@christian-bromann christian-bromann deleted the cb/custom-path branch May 1, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants