Added passport provider for ru_RU language #2066
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcurella
requested changes
Aug 1, 2024
|
|
||
|
|
||
| class Provider(PassportProvider): | ||
| def passport_owner(self, gender: str = "M") -> Tuple[str, str]: |
There was a problem hiding this comment.
you can use faker.typing.SexLiteral as type for the gender argument.
There was a problem hiding this comment.
Agree, let I will fix it!
Thanks for feedback.
fcurella
requested changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Added new passport provider for ru_RU language
What was wrong
It looks like based on an issue #2061 for passport_owners we need to return first surname and then given_name
How this fixes it
I created a new provider class in the path: faker/providers/passport/ru_RU/init.py and overloaded the function passport_owner