Add PIN Code range and union territories in en_IN address provider
#2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
en_IN - add pin code range in address
wh0th3h3llam1
commented
Aug 25, 2024
| "Jammu and Kashmir", | ||
| "Ladakh", | ||
| "Lakshadweep", | ||
| ("Pondicherry, Puducherry"), |
There was a problem hiding this comment.
Is it fine being a tuple?
There was a problem hiding this comment.
I would make them all tuples, even if they just have one element
fcurella
approved these changes
Aug 30, 2024
| "Jammu and Kashmir", | ||
| "Ladakh", | ||
| "Lakshadweep", | ||
| ("Pondicherry, Puducherry"), |
There was a problem hiding this comment.
I would make them all tuples, even if they just have one element
| "HP": (170_000, 179_999), | ||
| "JH": (800_000, 859_999), | ||
| "KA": (560_000, 599_999), | ||
| "KL": [(670_000, 681_999), (683_000, 699_999)], |
There was a problem hiding this comment.
can we make all items lists of tuples?
There was a problem hiding this comment.
If I make them list of tuples, I don't see how it would make a difference since it's meant to be never changed (unless a new state is created). I don't mind changing it to list of tuples as well. I'm just asking for your view
There was a problem hiding this comment.
I'd rather have all valueswith the same structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Updates the
addressprovider foren_INto add union territories and PIN code ranges for statesWhat was wrong
No state / union territories pin code specified
How this fixes it
Add state / union territories pin codes with ranges
Fixes #2089