Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Keras CV APIs for layers #1825

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sachinprasadhs
Copy link
Collaborator

Newly listed keras CV layers of

  • object_detection
  • object_detection_3d
  • preprocessing
  • regularization

Could not come up with the right category for Window Partitioning layer, commented it as of now.

Reorganized, Layers_master to have single nested structure, similar to Keras core.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

scripts/cv_api_master.py Outdated Show resolved Hide resolved
scripts/cv_api_master.py Outdated Show resolved Hide resolved
scripts/cv_api_master.py Outdated Show resolved Hide resolved
scripts/cv_api_master.py Outdated Show resolved Hide resolved
scripts/cv_api_master.py Outdated Show resolved Hide resolved
scripts/cv_api_master.py Outdated Show resolved Hide resolved
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

scripts/cv_api_master.py Show resolved Hide resolved
"path": "equalization",
"title": "Equalization layer",
"generate": ["keras_cv.layers.Equalization"],
"path": "decoder/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this section, it is redundant with modeling.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do I keep the FeaturePyramid and SpatialPyramidPooling layers.

"path": "modelling/",
"title": "Modelling layers",
"toc": True,
"children": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the sub-section and just put all the layers directly under modeling.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So will it be something like MODELING_MASTER?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants