Backporting support for Regional Instance Template GCE to 1.29 #7231
+176
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
area/provider/gce
size/XL
Edwinhr716
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Edwinhr716 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/L
Edwinhr716
changed the title
Edwinhr716
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Edwinhr716
changed the title
x13n
reviewed
Sep 5, 2024
| machinesCache: map[MachineTypeKey]MachineType{}, | ||
| migTargetSizeCache: map[GceRef]int64{}, | ||
| migBaseNameCache: map[GceRef]string{}, | ||
| listManagedInstancesResultsCache: map[GceRef]string{}, |
There was a problem hiding this comment.
Why add listManagedInstancesResultsCache? You don't seem to be using it anywhere and it wasn't a part of your original PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #6570 on cluster-autoscaler-release-1.29.
#6570: made changes to support MIGs that use regional instance
For details on the cherry pick process, see the cherry pick requests page.