Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting init containers for cluster-autoscaler #7267

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hegerdes
Copy link

@hegerdes hegerdes commented Sep 8, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

It adds the ability to run init (and sidecar) containers within the cluster-autoscaler deployment when installing via helm. A lot of providers depend on configuration options and files depending on their cloud provider. A init container or sidecar container would allow to execute any logic in order to get or create the autoscaler provider configuration dynamically.

Which issue(s) this PR fixes:

Fixes #
Not existing yet

Special notes for your reviewer:

Example and test usage:

helm template -f myvalue.yaml -s templates/deployment.yaml
# myvalue.yaml 
initContainers:
  - name: get-cloud-conf
    image: alpine:latest
    # Optionally make it a sidecar
    # restartPolicy: Always
    command: ["sh", "-c", "curl -sl https://my-cloud-conf.com/user-data -o /opt/user-data/scale.conf"]
    volumeMounts:
      - name: user-data
        mountPath: /opt/user-data

extraVolumeMounts:
  - name: user-data
    mountPath: /opt/user-data

extraVolumes:
  - name: user-data
    emptyDir: {}

autoDiscovery:
  clusterName: demo

Does this PR introduce a user-facing change?

feat: allow setting init containers via helm for cluster-autoscaler

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/helm-charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hegerdes
Once this PR has been reviewed and has the lgtm label, please assign gjtempleton for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @hegerdes!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 8, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @hegerdes. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 8, 2024
@hegerdes hegerdes force-pushed the feat/cluster-autoscaler-init-containers branch from 15f159e to c0518bf Compare September 8, 2024 13:30
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm-charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants