Undesired operation detection for L4 ILB #2682
Open
+487
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code to detect a situation when a service processing is a resync but causes GCE resource updates. This also touches the NetLB part, especially for the dual stack case, where some resources can be doubled (for example forwarding rule). Modification of just one should mark the resource type as updated.
… controller. This also renames the metric to reflect that it's about both NetLB and ILB. The metric has not been used anywhere yet so renaming is safe.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mmamczur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code to detect a situation when a service processing is a resync but causes GCE resource updates.
This is a follow up to #2616, the same change but for ILB.
The changes include some missing test coverage for areas that were touched by these changes.