-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an optional pull-kubernetes-coverage-unit presubmit #26276
Create an optional pull-kubernetes-coverage-unit presubmit #26276
Conversation
@dims - FYI |
presubmits: | ||
kubernetes/kubernetes: | ||
# The presubmit version of the ci-kubernetes-coverage-unit job. | ||
# conformance test using image against kubernetes master branch with `kind` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this comment related to this?
find ${ARTIFACTS} -type f -iname 'junit*.xml' -exec rm {} \; | ||
./gopherage filter --exclude-path="zz_generated,generated\.pb\.go" "${ARTIFACTS}/combined-coverage.out" > "${ARTIFACTS}/filtered.cov" || result=$? | ||
./gopherage junit --threshold 0.05 "${ARTIFACTS}/filtered.cov" > "${ARTIFACTS}/junit_coverage.xml" || result=$? | ||
exit $result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not running swallowing the error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point - changed
fd2cecf
to
5ff5264
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5ff5264
to
5f43eeb
Compare
/lgtm |
@wojtek-t: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ref #25966
/assign @BenTheElder @liggitt @aojea