-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamic layout basic support #1824
Open
JulianGCalderon
wants to merge
65
commits into
main
Choose a base branch
from
dynamic-layout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JulianGCalderon
force-pushed
the
dynamic-layout
branch
2 times, most recently
from
August 23, 2024 21:24
2ee787b
to
315594d
Compare
Benchmark Results for unmodified programs 🚀
|
JulianGCalderon
force-pushed
the
dynamic-layout
branch
from
August 23, 2024 21:56
4913d86
to
d03618c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1824 +/- ##
==========================================
+ Coverage 94.83% 94.85% +0.01%
==========================================
Files 101 101
Lines 39579 39828 +249
==========================================
+ Hits 37536 37779 +243
- Misses 2043 2049 +6 ☔ View full report in Codecov by Sentry. |
JulianGCalderon
force-pushed
the
dynamic-layout
branch
from
August 26, 2024 17:44
d03618c
to
864cdc5
Compare
JulianGCalderon
force-pushed
the
dynamic-layout
branch
from
August 26, 2024 17:49
864cdc5
to
adbba88
Compare
JulianGCalderon
force-pushed
the
dynamic-layout
branch
from
September 3, 2024 20:41
f06fce6
to
af9fadd
Compare
JulianGCalderon
requested review from
igaray,
Oppen,
fmoletta,
juanbono and
pefontana
as code owners
September 4, 2024 16:50
Benchmark Results for modified programs 🚀
|
JulianGCalderon
force-pushed
the
dynamic-layout
branch
from
September 18, 2024 18:03
2e2ad4d
to
a6f1511
Compare
6 tasks
They are going to be moved to another branch
JulianGCalderon
changed the title
Add dynamic layout support
Add dynamic layout basic support
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dynamic layout support
This PR doesn't change any logic in the VM, it only changes some signatures to allow for dynamic layout parameters. The missing functionality is being developed in #1838.
It also adds a new job to the CI for testing dynamic layouts in different scenarios.
I separated it this way to make reviewing easier.
Description
This PR adds support for dynamic layout. When using dynamic layout, the actual parameters of the layout must be specified through a path to a JSON file in the command line arguments:
Or, with Cairo 1:
To add this functionality, the public API had to be changed. Now both
CairoRunner::new
andCairoRunner::new_v2
receive as their 3rd argument anOption<CairoLayoutParams>
. This must beSome
only when using dynamic layout. Most changes in this PR are a side effect of this modification.Even though this is not the most "rustic" solution, it was done this way to facilitate usage and minimize changes needed.
The JSON file has the following format. I left an example in the repository's root just in case, it can be moved or removed.
Checklist