Remove default typename in Rollup GraphQL plugin

lemonmade · Aug 5, 2024 · c473811 · c473811
1 parent d91c56d
commit c473811
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 5 deletions.
diff --git a/.changeset/mighty-lies-hear.md b/.changeset/mighty-lies-hear.md
@@ -0,0 +1,5 @@
+---
+'@quilted/rollup': patch
+---
+
+Remove default typename in Rollup GraphQL plugin
diff --git a/packages/rollup/source/features/graphql.ts b/packages/rollup/source/features/graphql.ts
@@ -12,9 +12,10 @@ import {
 
 export interface GraphQLOptions {
   manifest?: string | boolean;
+  addTypename?: boolean;
 }
 
-export function graphql({manifest}: GraphQLOptions = {}): Plugin {
+export function graphql({manifest, addTypename}: GraphQLOptions = {}): Plugin {
   const shouldWriteManifest = Boolean(manifest);
   const manifestPath =
     typeof manifest === 'string' ? manifest : `manifests/graphql.json`;
@@ -45,6 +46,7 @@ export function graphql({manifest}: GraphQLOptions = {}): Plugin {
         cleanGraphQLDocument(loadedDocument, {
           removeUnused: {exclude: topLevelDefinitions},
         }),
+        {addTypename},
       );
 
       return {

diff --git a/packages/rollup/source/features/graphql/transform.ts b/packages/rollup/source/features/graphql/transform.ts
@@ -28,16 +28,24 @@ export function cleanGraphQLDocument<
   Variables = Record<string, any>,
 >(
   document: DocumentNode | TypedQueryDocumentNode<Data, Variables>,
-  {removeUnused = true}: {removeUnused?: boolean | {exclude: Set<string>}} = {},
+  {
+    removeUnused = true,
+    addTypename: shouldAddTypename = false,
+  }: {
+    removeUnused?: boolean | {exclude: Set<string>};
+    addTypename?: boolean;
+  } = {},
 ): EnhancedDocumentNode<Data, Variables> {
   if (removeUnused) {
     removeUnusedDefinitions(document, {
       exclude: removeUnused === true ? new Set() : removeUnused.exclude,
     });
   }
 
-  for (const definition of document.definitions) {
-    addTypename(definition);
+  if (shouldAddTypename) {
+    for (const definition of document.definitions) {
+      addTypename(definition);
+    }
   }
 
   const normalizedSource = minifyGraphQLSource(print(document));
@@ -82,10 +90,11 @@ export function extractGraphQLImports(rawSource: string) {
 
 export function toGraphQLOperation<Data = unknown, Variables = unknown>(
   documentOrSource: EnhancedDocumentNode<Data, Variables> | string,
+  options?: Parameters<typeof cleanGraphQLDocument>[1],
 ): GraphQLOperation<Data, Variables> {
   const document =
     typeof documentOrSource === 'string'
-      ? cleanGraphQLDocument(parse(documentOrSource))
+      ? cleanGraphQLDocument(parse(documentOrSource), options)
       : documentOrSource;
 
   return {