-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mechanism to synchronize and update services status #30
Open
danielSanchezQ
wants to merge
5
commits into
logos-co:main
Choose a base branch
from
danielSanchezQ:service-ready
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still missing documentation. Will be adding that next. |
danielSanchezQ
force-pushed
the
service-ready
branch
from
October 19, 2023 08:06
a4eaa29
to
824c87a
Compare
youngjoon-lee
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good! I just left a question below.
🚀 |
al8n
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a better and simpler approach than #29 . Responsibility is of the services implementations (With great power comes great responsibility) to understand the complexities of their services relationships.
How this works?
There is
tokio::sync::watch
channel handled by the service. Other services can subscribe and get updated requesting a watcher (watch::Receiver) from the calls in the overwatch_handle within services themselves.Service status do not update automatically, I think is more flexible as service may chose to mark when they are ready to work. Also when they have finished its exection.
StatusHandle
holds both parts of the sender/receiver parts of the watch channel and its clonable. That way the service can spawn tasks freely and send the handle to handle internal status as well.