Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/prev: Fetch descendants with more correctness #4286

Merged
merged 1 commit into from
Sep 17, 2024
Merged

next/prev: Fetch descendants with more correctness #4286

merged 1 commit into from
Sep 17, 2024

Conversation

essiene
Copy link
Collaborator

@essiene essiene commented Aug 16, 2024 •
edited
Loading

See context in this discussion

This is the last planned change for this issue, so marking this as the fixing PR.

Fixes #3947

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@essiene essiene force-pushed the essiene/push-psqruoxnkoyy branch 2 times, most recently from 62c0187 to 75b7379 Compare August 16, 2024 19:29
@essiene essiene force-pushed the essiene/push-psqruoxnkoyy branch 22 times, most recently from d4fcde4 to 9c9da31 Compare August 23, 2024 07:38
@essiene essiene force-pushed the essiene/push-psqruoxnkoyy branch 2 times, most recently from 1c3b69e to 3bd14c8 Compare August 24, 2024 14:54
Base automatically changed from essiene/push-psqruoxnkoyy to main August 25, 2024 08:58
@essiene essiene force-pushed the essiene/push-pouxyprmpnro branch 2 times, most recently from 63d5615 to f695719 Compare August 27, 2024 17:53
@essiene essiene force-pushed the essiene/push-pouxyprmpnro branch 3 times, most recently from 6121166 to 95263c1 Compare September 16, 2024 00:50
@essiene essiene requested a review from yuja September 16, 2024 00:56
yuja
yuja reviewed Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good to me, thanks.

cli/tests/test_next_prev_commands.rs Outdated Show resolved Hide resolved
@essiene essiene requested a review from yuja September 16, 2024 12:37
@essiene essiene mentioned this pull request Sep 16, 2024
Closed
4 tasks
yuja
yuja approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cli/src/movement_util.rs Show resolved Hide resolved
cli/tests/test_next_prev_commands.rs Outdated Show resolved Hide resolved
@essiene essiene changed the title refactor: Fetch descendants more correctly. next/prev: Fetch descendants with more correctness Sep 17, 2024
@essiene essiene enabled auto-merge (rebase) September 17, 2024 15:35
@essiene essiene merged commit e25ec53 into main Sep 17, 2024
31 checks passed
@essiene essiene deleted the essiene/push-pouxyprmpnro branch September 17, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuja yuja yuja approved these changes

@martinvonz martinvonz Awaiting requested review from martinvonz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FR: Add a always edit mode to prev/next
2 participants
@essiene @yuja