WIP: run all tests button and context menus #191
Conversation
lukester1975
force-pushed
the
buttons-and-context-menus
branch
from
7bafbcb
to
d9c81f3
Compare
| return item; | ||
| } | ||
|
|
||
| override getChildren() { | ||
| return this.tests.map((test) => new TestNode(this.id, test, this.isBenchmark)); | ||
| } | ||
|
|
||
| run() { |
There was a problem hiding this comment.
Can you add a return type?
There was a problem hiding this comment.
Can do, though it's from the IRunnable interface; not sure what the gain is other than more stuff to edit if the interface changes.
There was a problem hiding this comment.
To me, the gain is explicit return types. Helps when reading code. Everyone has different preferences though.
lukester1975
force-pushed
the
buttons-and-context-menus
branch
from
d9c81f3
to
a9aed52
Compare
|
I put back the header configure button as if there's no build dir, there would be no configure button... Was different with the multiple build dir support as there was a project-level node, with build dirs beneath it. |
|
This looks solid to me. Are you ready to go? |
|
Two things:
Feels like nowhere else in the ui does clicking on a non-leaf node not expand it. But maybe there's precedent elsewhere...
Cheers |
|
I agree with you on 1. If you want to add a build button, I think that would be a great addition! Did you get the icons from the CMake or CMake Tools extension? |
It was cmake tools. |
…project view. Build icons from vscode-cmake-tools.
Added an inline build button on a target node.
lukester1975
force-pushed
the
buttons-and-context-menus
branch
from
a9aed52
to
d440673
Compare
|
OK added a commit with that change. I need to take a look at the icon though. It's ugly when hovering over a selected target node (OK with dark theme):
|
|
BTW, icon is ugly in cmake plugin too. Dark mode is fine. |
First commit is the run/run all buttons in the meson view.
Second commit adds context menus all over the shop. Makes more sense on my old multiple builddir branch (e.g. I had hacked a very unpleasant debug command, but given the debug provider stuff, doesn't seem worth it unless that can be hooked in to; haven't looked), but maybe worth adding some now.
Personally, I don't like that clicking on a target builds it. Could add an inline button next to the
open meson.buildand just leave clicking on the node to expand it.Also moves the reconfigure button (if/when multiple root/builddirs are added, it doesn't make sense to have a reconfigure button in the sidebar's header).
Build icon came from the cmake plugin. Whether that would need attribution somewhere I've no idea...
Cheers