Expose the insertImageEditingWrapper api
#2787
Conversation
juliaroldi
requested review from
BryanValverdeU,
JiuqingSong,
ianeli1,
vinguyen12 and
Andres-CT98
|
Please wait |
| } else { | ||
| this.startRotateAndResize(editor, node); | ||
| } | ||
| node.onload = () => { |
There was a problem hiding this comment.
after node is loaded, need to remove this handler.
And what if load fails? we also need to remove the handler.
| /** | ||
| * Insert the image editing wrapper in the selected image | ||
| */ | ||
| public insertImageEditingWrapper() { |
There was a problem hiding this comment.
What is the different between this function and startRotateAndResize?
There was a problem hiding this comment.
The startRotateAndResize only handles the DOM manipulation, this one also handles the changes in content model.
This one gets the selected the image set isEditing in the image and when the image node is created call startRotateAndResize
There was a problem hiding this comment.
Where is the code to set isEditing?
There was a problem hiding this comment.
Under applyFormatWithContentModel function
| if (!this.editor.getEnvironment().isSafari) { | ||
| this.editor.focus(); // Safari will keep the selection when click crop, then the focus() call should not be called | ||
| } | ||
| if (this.editor && selection?.type == 'image') { |
There was a problem hiding this comment.
no need to check this.editor again here
| public insertImageEditingWrapper() { | ||
| if (this.editor) { | ||
| const selection = this.editor.getDOMSelection(); | ||
| if (!this.editor.getEnvironment().isSafari) { |
There was a problem hiding this comment.
we should also only do focus if selection is image, right? so move this under line 363
| /** | ||
| * Insert the image editing wrapper in the selected image | ||
| */ | ||
| public insertImageEditingWrapper() { |
There was a problem hiding this comment.
Where is the code to set isEditing?
Expose the
insertImageEditingWrapperapi to insert the resize and rotate wrapper into the selected image.